8276314: [JVMCI] check alignment of call displacement during code installation

[vnkozlov]

Backport for parity with 11.0.15-oracle. Changes slightly different from original fix in JDK 18. There are additional changes at lines 275-276 in nativeInst_x86.cpp.

Tier1-3 passed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8276314: [JVMCI] check alignment of call displacement during code installation

Reviewers

• Doug Simon (@dougxc - Committer)
• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/723/head:pull/723
$ git checkout pull/723

Update a local copy of the PR:
$ git checkout pull/723
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/723/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 723

View PR using the GUI difftool:
$ git pr show -t 723

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/723.diff

[bridgekeeper]

👋 Welcome back kvn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (323ea0e8)

[vnkozlov]

Backport was approved.

[vnkozlov]

/integrate

[openjdk]

@vnkozlov This pull request has not yet been marked as ready for integration.

[vnkozlov]

@GoeLin can you also formally approve it? Doug reviewed it but PR is still not marked as properly reviewed. I don't know why.

[GoeLin]

LGTM

[openjdk]

@vnkozlov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276314: [JVMCI] check alignment of call displacement during code installation

Reviewed-by: dnsimon, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• fdf21b6: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 2893731: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"
• cd8ea37: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
• fc54784: 8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
• bf7c965: 8277385: Zero: Enable CompactStrings support
• bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
• d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
• ec89f1b: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
• b07b90f: 8278309: [windows] use of uninitialized OSThread::_state
• 86c2995: 8202142: jfr/event/io/TestInstrumentation is unstable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

Here we go: "ready" -- no idea what was wrong.

[vnkozlov]

Thanks!!

[vnkozlov]

/integrate

[openjdk]

Going to push as commit 8989823.
Since your change was applied there have been 10 commits pushed to the master branch:

• fdf21b6: 8265150: AsyncGetCallTrace crashes on ResourceMark
• 2893731: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"
• cd8ea37: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
• fc54784: 8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
• bf7c965: 8277385: Zero: Enable CompactStrings support
• bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
• d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
• ec89f1b: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
• b07b90f: 8278309: [windows] use of uninitialized OSThread::_state
• 86c2995: 8202142: jfr/event/io/TestInstrumentation is unstable

Your commit was automatically rebased without conflicts.

[openjdk]

@vnkozlov Pushed as commit 8989823.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.