-
Notifications
You must be signed in to change notification settings - Fork 238
8265150: AsyncGetCallTrace crashes on ResourceMark #724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8265150: AsyncGetCallTrace crashes on ResourceMark #724
Conversation
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason that the new RegisterMap definition is placed after the definition of current_thread?
No, I can switch back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Zhengyu. Lgtm.
@zhengyu123 This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks for reviewing, @phohensee |
/integrate |
Going to push as commit fdf21b6.
Your commit was automatically rebased without conflicts. |
@zhengyu123 Pushed as commit fdf21b6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport to openjdk 11u for parity with Oracle 11.0.15.
The original patch does not apply cleanly. The conflicts is in jvmtiEnvBase.cpp due to surrounding context difference. Also, RegisterMap constructor in 11u does not take the third parameter (process_frames), which was introduced for concurrent stack processing in later version.
Test:
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/724/head:pull/724
$ git checkout pull/724
Update a local copy of the PR:
$ git checkout pull/724
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/724/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 724
View PR using the GUI difftool:
$ git pr show -t 724
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/724.diff