Skip to content

8265150: AsyncGetCallTrace crashes on ResourceMark #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

8265150: AsyncGetCallTrace crashes on ResourceMark #724

wants to merge 2 commits into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Dec 16, 2021

Backport to openjdk 11u for parity with Oracle 11.0.15.

The original patch does not apply cleanly. The conflicts is in jvmtiEnvBase.cpp due to surrounding context difference. Also, RegisterMap constructor in 11u does not take the third parameter (process_frames), which was introduced for concurrent stack processing in later version.

Test:

  • tier1 on Linux x86_64

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265150: AsyncGetCallTrace crashes on ResourceMark

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/724/head:pull/724
$ git checkout pull/724

Update a local copy of the PR:
$ git checkout pull/724
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/724/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 724

View PR using the GUI difftool:
$ git pr show -t 724

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/724.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 16, 2021

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 267c024eb52acd1611188dd5b1417b877ff3eafd 8265150: AsyncGetCallTrace crashes on ResourceMark Dec 16, 2021
@openjdk
Copy link

openjdk bot commented Dec 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 16, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 16, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason that the new RegisterMap definition is placed after the definition of current_thread?

@zhengyu123
Copy link
Contributor Author

Is there a reason that the new RegisterMap definition is placed after the definition of current_thread?

No, I can switch back.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Zhengyu. Lgtm.

@openjdk
Copy link

openjdk bot commented Dec 17, 2021

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265150: AsyncGetCallTrace crashes on ResourceMark

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 86c2995: 8202142: jfr/event/io/TestInstrumentation is unstable

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 17, 2021
@zhengyu123
Copy link
Contributor Author

Thanks, Zhengyu. Lgtm.

Thanks for reviewing, @phohensee

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2021

Going to push as commit fdf21b6.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 2893731: 8276177: nsk/jvmti/RedefineClasses/StressRedefineWithoutBytecodeCorruption failed with "assert(def_ik->is_being_redefined()) failed: should be being redefined to get here"
  • cd8ea37: 8273638: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • fc54784: 8258554: javax/swing/JTable/4235420/bug4235420.java fails in GTK L&F
  • bf7c965: 8277385: Zero: Enable CompactStrings support
  • bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx
  • ec89f1b: 8274736: Concurrent read/close of SSLSockets causes SSLSessions to be invalidated unnecessarily
  • b07b90f: 8278309: [windows] use of uninitialized OSThread::_state
  • 86c2995: 8202142: jfr/event/io/TestInstrumentation is unstable

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2021
@openjdk
Copy link

openjdk bot commented Dec 22, 2021

@zhengyu123 Pushed as commit fdf21b6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants