Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277385: Zero: Enable CompactStrings support #726

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 21, 2021

Clean backport to improve Zero performance.

Additional testing:

  • Linux x86_64 Zero fastdebug make bootcycle-images

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/726/head:pull/726
$ git checkout pull/726

Update a local copy of the PR:
$ git checkout pull/726
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/726/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 726

View PR using the GUI difftool:
$ git pr show -t 726

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/726.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 21, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3f847fe89a088d6921107ca887a7a1bace871bd6 8277385: Zero: Enable CompactStrings support Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277385: Zero: Enable CompactStrings support

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Dec 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 21, 2021

Webrevs

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 22, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

Going to push as commit bf7c965.
Since your change was applied there have been 2 commits pushed to the master branch:

  • bd97b56: 8278116: runtime/modules/LoadUnloadModuleStress.java has duplicate -Xmx
  • d3c2dc0: 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready rfr labels Dec 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@shipilev Pushed as commit bf7c965.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8277385-zero-compactstrings branch Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant