Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx #727

Closed

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Dec 21, 2021

Test backport to improve testing. Does not apply cleanly, because the test have not been moved in the separate package (done in bulk later).

Additional testing:

  • Linux x86_64 fastdebug, affected test still passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/727/head:pull/727
$ git checkout pull/727

Update a local copy of the PR:
$ git checkout pull/727
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/727/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 727

View PR using the GUI difftool:
$ git pr show -t 727

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/727.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 21, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0fbd2713f1b47c343172fa34be021706c957520e 8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx Dec 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Dec 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 21, 2021

Webrevs

GoeLin
GoeLin approved these changes Dec 22, 2021
Copy link
Member

@GoeLin GoeLin left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278115: gc/stress/gclocker/TestGCLockerWithSerial.java has duplicate -Xmx

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Dec 22, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Dec 22, 2021

Got the push approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

Going to push as commit d3c2dc0.

@openjdk openjdk bot added the integrated label Dec 22, 2021
@openjdk openjdk bot closed this Dec 22, 2021
@openjdk openjdk bot removed ready rfr labels Dec 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 22, 2021

@shipilev Pushed as commit d3c2dc0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8278115-gclocker-duplicate-xmx branch Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants