8279077: JFR crashes on Linux ppc due to missing crash protector in signal handler #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Welcome back zgu! A progress list of the required criteria for merging this PR into |
|
Perhaps this should be fixed in JDK 15, then backported? Otherwise the JBS issue history will be a bit confused. |
I am not sure about which version it should go to first. I chose JDK 11, since it is the closet TLS. Do we have any guideline on this? |
|
The standard process is to fix a problem in the latest release in which it appears, then backport it. So, I'd start with 15. |
|
Moved PR to JDK15u. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a linux_ppc specific bug, probably a day-one bug till relevant code was refactored by JDK-8255711 in 16.
Linux ppc signal handler does not install crash protector as other Linux based platforms do, e.g. linux_x86, that can result a crash while jfr tries to fill stack trace for other thread.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/729/head:pull/729$ git checkout pull/729Update a local copy of the PR:
$ git checkout pull/729$ git pull https://git.openjdk.java.net/jdk11u-dev pull/729/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 729View PR using the GUI difftool:
$ git pr show -t 729Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/729.diff