Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor #732

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 30, 2021

Hi all,
This pull request contains a backport of commit 03473b4c from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 18 Nov 2021 and was reviewed by Jayathirth D V.

The patch is not clean due to copyright date conflict. The jdk_desktop tests are green on the system where the bug was reproduced.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/732/head:pull/732
$ git checkout pull/732

Update a local copy of the PR:
$ git checkout pull/732
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/732/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 732

View PR using the GUI difftool:
$ git pr show -t 732

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/732.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 30, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03473b4c271b2ec7f0ebdb0edabadf7f36816b9d 8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor Dec 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 30, 2021
@mrserb mrserb marked this pull request as ready for review Dec 30, 2021
@openjdk openjdk bot added the rfr label Dec 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 30, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2022

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270874: JFrame paint artifacts when dragged from standard monitor to HiDPI monitor

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 80 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 13, 2022
@GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 20, 2022

Hint: if the only thing you had to resolve was a copyright year, you can use the /clean command.
Please elaborate what you had to resolve, though. This saves the reivew...

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 22, 2022

/clean

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 22, 2022

There is only a copyright date change.

@openjdk openjdk bot added the clean label Jan 22, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 22, 2022

@mrserb This backport pull request is now marked as clean

@mrserb
Copy link
Member Author

@mrserb mrserb commented Jan 23, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 23, 2022

Going to push as commit d91ce05.
Since your change was applied there have been 83 commits pushed to the master branch:

  • 8ce9564: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • 809b015: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop
  • efe46bb: 8275610: C2: Object field load floats above its null check resulting in a segfault
  • 716ceb7: 8266421: Deadlock in Sound System
  • b5cae57: 8274795: AArch64: avoid spilling and restoring r18 in macro assembler
  • 914d48c: 8232533: G1 uses only a single thread for pretouching the java heap
  • ec03928: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • cba6c04: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
  • 521144c: 8251998: remove usage of PropertyResolvingWrapper in vmTestbase/jit/t
  • f69e75f: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
  • ... and 73 more: https://git.openjdk.java.net/jdk11u-dev/compare/9fb29891b6e14b01ac2ad1e5ee10591532497a72...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 23, 2022
@openjdk openjdk bot closed this Jan 23, 2022
@openjdk openjdk bot removed ready rfr labels Jan 23, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 23, 2022

@mrserb Pushed as commit d91ce05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the mrserb-backport-03473b4c branch Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants