Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default #733

Closed

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Dec 30, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/733/head:pull/733
$ git checkout pull/733

Update a local copy of the PR:
$ git checkout pull/733
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/733/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 733

View PR using the GUI difftool:
$ git pr show -t 733

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/733.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 30, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1413f9e070b19bed33a4552f3e7adb53cf7daf73 8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default Dec 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 30, 2021

@DamonFool This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241423: NUMA APIs fail to work in dockers due to dependent syscalls are disabled by default

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Dec 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 30, 2021

Webrevs

@DamonFool
Copy link
Member Author

@DamonFool DamonFool commented Dec 31, 2021

Fix request had been approved.
So integrate it.
Thanks.

/integrate

@openjdk openjdk bot added the sponsor label Dec 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2021

@DamonFool
Your change (at version 7ae9242) is now ready to be sponsored by a Committer.

@johnshajiang
Copy link
Member

@johnshajiang johnshajiang commented Dec 31, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2021

Going to push as commit d356b89.

@openjdk openjdk bot added the integrated label Dec 31, 2021
@openjdk openjdk bot closed this Dec 31, 2021
@openjdk openjdk bot removed ready rfr sponsor labels Dec 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 31, 2021

@johnshajiang @DamonFool Pushed as commit d356b89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants