Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux #742

Closed
wants to merge 1 commit into from
Closed

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Jan 5, 2022

A clean backport for parity with Oracle 11.0.15.

This is a test only patch, no risk.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/742/head:pull/742
$ git checkout pull/742

Update a local copy of the PR:
$ git checkout pull/742
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/742/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 742

View PR using the GUI difftool:
$ git pr show -t 742

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/742.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 5, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0d938cedcaf55886058b94dc280a8f7181c79fdf 8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux Jan 5, 2022
@openjdk
Copy link

openjdk bot commented Jan 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 5, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278172: java/nio/channels/FileChannel/BlockDeviceSize.java should only run on Linux

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 5, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 5, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

Going to push as commit fee3955.
Since your change was applied there have been 7 commits pushed to the master branch:

  • f7998d6: 8279077: JFR crashes on Linux ppc due to missing crash protector in signal handler
  • e1ee008: 8279225: [arm32] C1 longs comparison operation destroys argument registers
  • 7e7043e: 8276623: JDK-8275650 accidentally pushed "out" file
  • 914fb55: 8279379: GHA: Print tests that are in error
  • a96e70c: 8275536: Add test to check that File::lastModified returns same time stamp as Files.getLastModifiedTime
  • 2ccf515: 8274658: ISO 4217 Amendment 170 Update
  • fb39476: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2022
@openjdk openjdk bot closed this Jan 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@zhengyu123 Pushed as commit fee3955.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant