Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279225: [arm32] C1 longs comparison operation destroys argument registers #743

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 6, 2022

Clean backport to fix ARM32 and get parity with 11.0.5-oracle.

Additional testing:

  • java/math/BigDecimal/DivideMcTests.java with -XX:+TieredCompilation on ARM32 fails before the patch, passes with it

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8279225: [arm32] C1 longs comparison operation destroys argument registers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/743/head:pull/743
$ git checkout pull/743

Update a local copy of the PR:
$ git checkout pull/743
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 743

View PR using the GUI difftool:
$ git pr show -t 743

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/743.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 6, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 299022dfacbcb49e3bc5beca8ff9b1fca1101493 8279225: [arm32] C1 longs comparison operation destroys argument registers Jan 6, 2022
@openjdk
Copy link

openjdk bot commented Jan 6, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 6, 2022

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279225: [arm32] C1 longs comparison operation destroys argument registers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • be7343d: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 6, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 6, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

Going to push as commit e1ee008.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 7e7043e: 8276623: JDK-8275650 accidentally pushed "out" file
  • 914fb55: 8279379: GHA: Print tests that are in error
  • a96e70c: 8275536: Add test to check that File::lastModified returns same time stamp as Files.getLastModifiedTime
  • 2ccf515: 8274658: ISO 4217 Amendment 170 Update
  • fb39476: 8239502: [TEST_BUG] Test javax/swing/text/FlowView/6318524/bug6318524.java never fails
  • be7343d: 8277342: vmTestbase/nsk/stress/strace/strace004.java fails with SIGSEGV in InstanceKlass::jni_id_for

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2022
@openjdk openjdk bot closed this Jan 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@shipilev Pushed as commit e1ee008.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279225-arm32-long branch April 6, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant