Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256154: Some TestNG tests require default constructors #747

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 10, 2022

I backport this for parity with 11.0.15-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8256154: Some TestNG tests require default constructors

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/747/head:pull/747
$ git checkout pull/747

Update a local copy of the PR:
$ git checkout pull/747
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/747/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 747

View PR using the GUI difftool:
$ git pr show -t 747

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/747.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5ed704484eae23a8b3feb1ac705d23b5eb0dfc40 8256154: Some TestNG tests require default constructors Jan 10, 2022
@openjdk
Copy link

openjdk bot commented Jan 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256154: Some TestNG tests require default constructors

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 10, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 11, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 11, 2022

Going to push as commit 1c7af7e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 5c08cfd: 8237787: rewrite vmTestbase/vm/compiler/CodeCacheInfo* from shell to java
  • c3be035: 8223142: Clean-up WS and CB.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 11, 2022
@openjdk openjdk bot closed this Jan 11, 2022
@openjdk openjdk bot removed ready rfr labels Jan 11, 2022
@openjdk
Copy link

openjdk bot commented Jan 11, 2022

@GoeLin Pushed as commit 1c7af7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant