Skip to content

8266352: Add parallel heap iteration for jmap –histo #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from
Closed

8266352: Add parallel heap iteration for jmap –histo #75

wants to merge 0 commits into from

Conversation

buddyliao
Copy link
Contributor

@buddyliao buddyliao commented Jun 29, 2021

8215624: Add parallel heap iteration for jmap -histo
8251570: JDK-8215624 causes assert(worker_id <' _n_workers) failed: Invalid worker_id
8253763: ParallelObjectIterator should have virtual destructor


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Integration blocker

 ⚠️ Issue of type Backport is not allowed for integrations

Issue

  • JDK-8266352: Add parallel heap iteration for jmap –histo

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/75/head:pull/75
$ git checkout pull/75

Update a local copy of the PR:
$ git checkout pull/75
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/75/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 75

View PR using the GUI difftool:
$ git pr show -t 75

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/75.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2021

👋 Welcome back buddyliao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 29, 2021

⚠️ @buddyliao a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master 52cbf2f653a9d36932f16ccbab7b61a1918cd18e
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@buddyliao
Copy link
Contributor Author

/jdk11u-fix-request

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 29, 2021
@buddyliao buddyliao changed the title 8215624: Add parallel heap iteration for jmap histo 8215624: Add parallel heap iteration for jmap -histo Jun 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2021

Webrevs

@buddyliao
Copy link
Contributor Author

Fix Request

@buddyliao buddyliao changed the title 8215624: Add parallel heap iteration for jmap -histo 8266352: Add parallel heap iteration for jmap –histo Jun 29, 2021
@buddyliao buddyliao changed the title 8266352: Add parallel heap iteration for jmap –histo Backport: 3498a10a2b4cfcdf219b4433124a2358eb6100c9 Jun 29, 2021
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jun 29, 2021
@buddyliao buddyliao changed the title Backport: 3498a10a2b4cfcdf219b4433124a2358eb6100c9 8266352: Add parallel heap iteration for jmap –histo Jun 29, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 29, 2021
@RealCLanger
Copy link
Contributor

Hi @buddyliao, can you this backport in 3 separate PRs? I think none of these breaks the build so it's ok to go one by one. Thanks!

@buddyliao buddyliao closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants