Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8232533: G1 uses only a single thread for pretouching the java heap #751

Closed
wants to merge 1 commit into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented Jan 12, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8232533: G1 uses only a single thread for pretouching the java heap

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/751/head:pull/751
$ git checkout pull/751

Update a local copy of the PR:
$ git checkout pull/751
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/751/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 751

View PR using the GUI difftool:
$ git pr show -t 751

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/751.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jan 12, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

Hi @yftsai, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user yftsai" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@yftsai
Copy link
Contributor Author

yftsai commented Jan 12, 2022

/covered

@openjdk openjdk bot changed the title Backport 9611320f6921aab26c2b84fdd0a133fd6dd0eb12 8232533: G1 uses only a single thread for pretouching the java heap Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jan 12, 2022
@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Jan 12, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2022

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk openjdk bot added the clean label Jan 12, 2022
@simonis
Copy link
Member

simonis commented Jan 14, 2022

Hi @robilad (or whoever else approves the OCA coverage),

I can confirm that @yftsai (Yi-Fan Tsai) is a member of the Corretto team at Amazon and covered by Amazon's company-wide OCA.

Best regards,
Vollker

@bridgekeeper bridgekeeper bot removed oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status labels Jan 18, 2022
@openjdk
Copy link

openjdk bot commented Jan 18, 2022

@yftsai This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232533: G1 uses only a single thread for pretouching the java heap

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 18, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Jan 20, 2022

@yftsai , please enable Pre-submit tests!

@yftsai
Copy link
Contributor Author

yftsai commented Jan 20, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 20, 2022
@openjdk
Copy link

openjdk bot commented Jan 20, 2022

@yftsai
Your change (at version 61c0222) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit 914d48c.
Since your change was applied there have been 59 commits pushed to the master branch:

  • ec03928: 8273933: [TESTBUG] Test must run without preallocated exceptions
  • cba6c04: 8268542: serviceability/logging/TestFullNames.java tests only 1st test case
  • 521144c: 8251998: remove usage of PropertyResolvingWrapper in vmTestbase/jit/t
  • f69e75f: 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests
  • 574c04c: 8273433: Enable parallelism in vmTestbase_nsk_sysdict tests
  • 5ffd40d: 8273341: Update Siphash to version 1.0
  • 0c4803b: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 3352b56: 8275326: C2: assert(no_dead_loop) failed: dead loop detected
  • ad94355: 8251127: clean up FileInstaller $test.src $cwd in remaining vmTestbase_vm_compiler tests
  • 9ca6369: 8252005: narrow disabling of allowSmartActionArgs in vmTestbase
  • ... and 49 more: https://git.openjdk.java.net/jdk11u-dev/compare/5a3a17bf2b5e8ff9cf22e6de12b8e6d6dfc26045...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@phohensee @yftsai Pushed as commit 914d48c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yftsai yftsai deleted the pretouch branch October 12, 2022 15:43
@yftsai yftsai restored the pretouch branch October 12, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants