Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277328: jdk/jshell/CommandCompletionTest.java failures on Windows #757

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 13, 2022

We see this bug in 11, too, so I would like to backport this fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/757/head:pull/757
$ git checkout pull/757

Update a local copy of the PR:
$ git checkout pull/757
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/757/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 757

View PR using the GUI difftool:
$ git pr show -t 757

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/757.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3955b037da8a0981d8efc67f28caaacdef7dfb31 8277328: jdk/jshell/CommandCompletionTest.java failures on Windows Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277328: jdk/jshell/CommandCompletionTest.java failures on Windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Jan 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 14, 2022

Going to push as commit 96c8499.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 3a96302: 8251132: make main classes public in vmTestbase/jit tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 14, 2022
@openjdk openjdk bot closed this Jan 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 14, 2022
@openjdk
Copy link

openjdk bot commented Jan 14, 2022

@GoeLin Pushed as commit 96c8499.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant