Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8214026: Canonicalized archive paths appearing in diagnostics #758

Closed
wants to merge 1 commit into from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Jan 13, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8214026: Canonicalized archive paths appearing in diagnostics

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/758/head:pull/758
$ git checkout pull/758

Update a local copy of the PR:
$ git checkout pull/758
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 758

View PR using the GUI difftool:
$ git pr show -t 758

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/758.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 13, 2022

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bddbbd85f97a29db8236b437e0a391fe316aa5c0 8214026: Canonicalized archive paths appearing in diagnostics Jan 13, 2022
@openjdk
Copy link

openjdk bot commented Jan 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 13, 2022

@cushon This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214026: Canonicalized archive paths appearing in diagnostics

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 13, 2022

Webrevs

@cushon cushon closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review
1 participant