Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8163326: Update the default enabled cipher suites preference #76

Closed
wants to merge 1 commit into from

Conversation

@alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Jun 29, 2021

I'd like to backport JDK-8163326 for parity with Oracle and align the list of cipher suites with other versions.

The original patch applies clean but I had to update test/jdk/javax/net/ssl/sanity/ciphersuites/CipherSuitesInOrder.java test because of the list of ciphers was not updated during JDK-8234728 backport to 11u

sun/security/ssl and javax/net/ssl tests passed successfully


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8163326: Update the default enabled cipher suites preference

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/76/head:pull/76
$ git checkout pull/76

Update a local copy of the PR:
$ git checkout pull/76
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/76/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 76

View PR using the GUI difftool:
$ git pr show -t 76

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/76.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d812742d687cf6e8748d65552831f60be156c860 8163326: Update the default enabled cipher suites preference Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 29, 2021

Looks good. Thanks for doing the backport. I see that test CipherSuitesInOrder.java now is the same as in head. Will approve once it ran successfully through our nightlies...

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8163326: Update the default enabled cipher suites preference

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems
  • 0e4fdcf: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
  • 725e516: Merge
  • a24f045: Added tag jdk-11.0.12+6 for changeset 91e81ac08854
  • bb5b2cb: 8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired
  • f31c90f: 8268699: Shenandoah: Add test for JDK-8268127

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 1, 2021
@alexeybakhtin
Copy link
Contributor Author

@alexeybakhtin alexeybakhtin commented Jul 1, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@alexeybakhtin
Your change (at version 15e1877) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 1, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit af4b373.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems
  • 0e4fdcf: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
  • 725e516: Merge
  • a24f045: Added tag jdk-11.0.12+6 for changeset 91e81ac08854
  • bb5b2cb: 8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired
  • f31c90f: 8268699: Shenandoah: Add test for JDK-8268127

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@RealCLanger @alexeybakhtin Pushed as commit af4b373.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants