Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image #77

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 29, 2021

This is a Graal VM native-image enable patch. native-image uses static libraries of OpenJDK. For awt libs dynamic symbols shouldn't be used. From a regular, non-static, OpenJDK perspective this should be a no-op. JDK 17 patch applies clean.

Testing: :jdk_desktop tests and linux x86_64 tier 1. No regressions observed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/77/head:pull/77
$ git checkout pull/77

Update a local copy of the PR:
$ git checkout pull/77
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/77/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 77

View PR using the GUI difftool:
$ git pr show -t 77

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/77.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 29, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7977e381ea9185dea063b09b3623accdbb97f560 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image Jun 29, 2021
@openjdk
Copy link

openjdk bot commented Jun 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 29, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 29, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 30, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 30, 2021

Going to push as commit 0e4fdcf.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 725e516: Merge
  • a24f045: Added tag jdk-11.0.12+6 for changeset 91e81ac08854
  • bb5b2cb: 8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 30, 2021
@openjdk
Copy link

openjdk bot commented Jun 30, 2021

@jerboaa Pushed as commit 0e4fdcf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant