Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests #779

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jan 19, 2022

Clean backport to improve testing performance.

Additional testing:

  • Linux x86_64 fastdebug vmTestbase/metaspace/stressHierarchy passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/779/head:pull/779
$ git checkout pull/779

Update a local copy of the PR:
$ git checkout pull/779
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/779/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 779

View PR using the GUI difftool:
$ git pr show -t 779

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/779.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 19, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a143372818ffab635b0e97208be53569b159a98b 8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests Jan 19, 2022
@openjdk
Copy link

openjdk bot commented Jan 19, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 19, 2022

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273438: Enable parallelism in vmTestbase/metaspace/stressHierarchy tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 19, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 19, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 21, 2022

Going to push as commit f69e75f.
Since your change was applied there have been 38 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 21, 2022
@openjdk openjdk bot closed this Jan 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2022
@openjdk
Copy link

openjdk bot commented Jan 21, 2022

@shipilev Pushed as commit f69e75f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273438-vmTestbase-stressHierarchy branch April 6, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant