Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build #78

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jun 29, 2021

Backport of this test fix since it applies to jdk11u as well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/78/head:pull/78
$ git checkout pull/78

Update a local copy of the PR:
$ git checkout pull/78
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/78/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 78

View PR using the GUI difftool:
$ git pr show -t 78

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/78.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 29, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d042029509a8cbdb723f78e2cfee4e2885775814 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build Jun 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 29, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 29, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit 65fe466.
Since your change was applied there have been 6 commits pushed to the master branch:

  • af4b373: 8163326: Update the default enabled cipher suites preference
  • 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems
  • 0e4fdcf: 8254024: Enhance native libs for AWT and Swing to work with GraalVM Native Image
  • 725e516: Merge
  • a24f045: Added tag jdk-11.0.12+6 for changeset 91e81ac08854
  • bb5b2cb: 8268678: LetsEncryptCA.java test fails as Let’s Encrypt Authority X3 is retired

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@RealCLanger Pushed as commit 65fe466.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant