8274471: Add support for RSASSA-PSS in OCSP Response #787
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to backport
8274471: Add support for RSASSA-PSS in OCSP Response
8179503: Java should support GET OCSP calls (dependency)
to jdk11u-dev.
The patches fix internal error upon verification of OCSP Response signed with RSASSA-PSS.
The following changes were done to original patches:
8179503:
src/java.base/share/classes/sun/security/provider/certpath/OCSP.java
test/jdk/java/security/cert/CertPathValidator/OCSP/GetAndPostTests.java
ObjectIdentifier.of()substituted withnew ObjectIdentifier8274471:
src/java.base/share/classes/sun/security/provider/certpath/OCSP.java
src/java.base/share/classes/sun/security/util/SignatureUtil.java
public static Signature fromKey(String sigAlg, PrivateKey key, String provider);public static Signature fromKey(String sigAlg, PrivateKey key, Provider provider);private static Signature autoInitInternal(String alg, PrivateKey key, Signature s);public static AlgorithmId fromSignature(Signature sigEngine, PrivateKey key);EdEcKey(unsupported in jdk11) hook removed from fromSignature() methodSignatureUtil.autoInitInternal()method updated to useAlgorithmId.getDefaultAlgorithmParameterSpec()instead ofSignatureUtil.getDefaultParamSpec()test/jdk/java/security/testlibrary/SimpleOCSPServer.java
Verified (20.04 LTS/amd64) with
Regression: jdk_security
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/787/head:pull/787$ git checkout pull/787Update a local copy of the PR:
$ git checkout pull/787$ git pull https://git.openjdk.java.net/jdk11u-dev pull/787/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 787View PR using the GUI difftool:
$ git pr show -t 787Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/787.diff