8218546: Unable to connect to https://google.com using java.net.HttpClient

[shipilev]

Clean backport to fix 11.0.14 regression. There are multiple reports about this breakage.

Additional testing:

• New regression test fails without the fix, passes with it
• Linux x86_64 {fastdebug, release}, java/net/httpclient passes
• Linux x86_64 {fastdebug, release}, tier1 passes
• Linux x86_64 {fastdebug, release}, tier2 passes
• Linux x86_64 {fastdebug, release}, tier3 passes

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8218546: Unable to connect to https://google.com using java.net.HttpClient

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/798/head:pull/798
$ git checkout pull/798

Update a local copy of the PR:
$ git checkout pull/798
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/798/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 798

View PR using the GUI difftool:
$ git pr show -t 798

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/798.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218546: Unable to connect to https://google.com using java.net.HttpClient

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• b6df150: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
• 84ed967: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
• 8352e38: 8273277: C2: Move conditional negation into rc_predicate
• 9700ded: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
• e279d07: 8236210: javac generates wrong annotation for fields generated from record components
• e651f09: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (9dc90f02)

[GoeLin]

Shouldn't this go directly to jdk11u? Or do you first want to push it to jdk11u-dev for testing?

[shipilev]

Shouldn't this go directly to jdk11u? Or do you first want to push it to jdk11u-dev for testing?

Would it matter to push it to jdk11u at this point? What does it buy us? The 11.0.14 ship had sailed already...

[GoeLin]

We could ship an 11.0.14.1. We did so once before: https://github.com/openjdk/jdk11u-dev/releases/tag/jdk-11.0.9.1-ga
Maybe we would also include 8280786.
If so, we should push a version bump.

[shipilev]

All right, that seems to hinge on a decision to actually ship 11.0.14.1. Meanwhile, maybe we should push this to jdk11u-dev, and then cherry pick if we decide to do 11.0.14.1?

[GoeLin]

I'm fine with that :)

[shipilev]

All right then, all my testing is green, the push approval received, I am integrating.

/integrate

[openjdk]

Going to push as commit b240c60.
Since your change was applied there have been 6 commits pushed to the master branch:

• b6df150: 8278758: runtime/BootstrapMethod/BSMCalledTwice.java fails with release VMs after JDK-8262134
• 84ed967: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
• 8352e38: 8273277: C2: Move conditional negation into rc_predicate
• 9700ded: 8253197: vmTestbase/nsk/jvmti/StopThread/stopthrd007/TestDescription.java fails with "ERROR: DebuggeeSleepingThread: ThreadDeath lost"
• e279d07: 8236210: javac generates wrong annotation for fields generated from record components
• e651f09: 8236505: Mark jdk/editpad/EditPadTest.java as @headful

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit b240c60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[jerboaa]

We could ship an 11.0.14.1. We did so once before: https://github.com/openjdk/jdk11u-dev/releases/tag/jdk-11.0.9.1-ga Maybe we would also include 8280786. If so, we should push a version bump.

11.0.9.1 was done in order to alleviate a potential JVM crash:
https://bugs.openjdk.java.net/browse/JDK-8250861

In hindsight it probably wasn't necessary to do a patch release. Either way, it's a very different kind of bug than this one. https://bugs.openjdk.java.net/browse/JDK-8218546?focusedCommentId=14243081&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14243081 suggests it's a peculiarity of Google servers.

I'm not convinced this warrants a patch update. 11.0.15 should be fine, IMO.

[tsenovIvan]

Hello,

For the past 2 days we have been fighting with this topic.
Turns out that nginx 1.20.0 also forbids this behavior and returns 400 bad request.
Could be only this version, or the specific version included in Amazon Linux 2. I don't know if they make their own changes.

Best,
Ivan