Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196092: javax/swing/JComboBox/8032878/bug8032878.java fails #8

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 2, 2021

I'd like to backport this test fix to 11u too since the same is fixed in 8u for symmetry. The JDK 17 patch didn't apply cleanly due to differences in ProblemList.txt. Note that JDK-8196439 refers to the same commit than JDK-8196092 (this bug). So it's fine to remove both listings in ProblemList.txt referring to that test. Thoughts?

Testing: test failed prior the fix, passes after.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196092: javax/swing/JComboBox/8032878/bug8032878.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/8/head:pull/8
$ git checkout pull/8

Update a local copy of the PR:
$ git checkout pull/8
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/8/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 8

View PR using the GUI difftool:
$ git pr show -t 8

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/8.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 2, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2ee795d9e495ea5cb6e1a41f48406291dc0e5e58 8196092: javax/swing/JComboBox/8032878/bug8032878.java fails Jun 2, 2021
@openjdk
Copy link

openjdk bot commented Jun 2, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 2, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 2, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for backporting!

@openjdk
Copy link

openjdk bot commented Jun 7, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8196092: javax/swing/JComboBox/8032878/bug8032878.java fails

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • d3a5ed2: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly
  • f55ef1e: 8210495: compiler crashes because of illegal signature in otherwise legal code
  • e6d0e9d: 8266642: Improve ResolvedMethodTable hash function
  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 7, 2021
@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 7, 2021

Thanks for the review, @TheRealMDoerr

@jerboaa
Copy link
Contributor Author

jerboaa commented Jun 8, 2021

/integrate

@openjdk openjdk bot closed this Jun 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 8, 2021
@openjdk
Copy link

openjdk bot commented Jun 8, 2021

@jerboaa Since your change was applied there have been 8 commits pushed to the master branch:

  • d3a5ed2: 8267773: PhaseStringOpts::int_stringSize doesn't handle min_jint correctly
  • f55ef1e: 8210495: compiler crashes because of illegal signature in otherwise legal code
  • e6d0e9d: 8266642: Improve ResolvedMethodTable hash function
  • 5c35022: 8211296: Remove HotSpot deprecation warning suppression for Mac/clang
  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821

Your commit was automatically rebased without conflicts.

Pushed as commit 6deb21f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants