Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8177814: jdk/editpad is not in jdk TEST.groups #801

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 30, 2022

I backport this for parity with 11.0.15-oracle.

I had to resolve because of different context.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/801/head:pull/801
$ git checkout pull/801

Update a local copy of the PR:
$ git checkout pull/801
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/801/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 801

View PR using the GUI difftool:
$ git pr show -t 801

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/801.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 30, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cfe7471f1769eca2a4e623f5ba9cddceb005f0bf 8177814: jdk/editpad is not in jdk TEST.groups Jan 30, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jan 30, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 30, 2022

Webrevs

Copy link
Member

@MBaesken MBaesken left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Jan 31, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8177814: jdk/editpad is not in jdk TEST.groups

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 31, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Feb 1, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2022

Going to push as commit ef288cd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 10b1839: 8279702: [macosx] ignore xcodebuild warnings on M1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 1, 2022
@openjdk openjdk bot closed this Feb 1, 2022
@openjdk openjdk bot removed ready rfr labels Feb 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2022

@GoeLin Pushed as commit ef288cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8177814 branch Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants