Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264650: Cross-compilation to macos/aarch64 #807

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Feb 4, 2022

Clean backport, to be done in advance of jep-391 backport


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/807/head:pull/807
$ git checkout pull/807

Update a local copy of the PR:
$ git checkout pull/807
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/807/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 807

View PR using the GUI difftool:
$ git pr show -t 807

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/807.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 4, 2022

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7f9ece23dc62e911c78be3fa4b8e297e3ac90bd1 8264650: Cross-compilation to macos/aarch64 Feb 4, 2022
@openjdk
Copy link

openjdk bot commented Feb 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 4, 2022

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264650: Cross-compilation to macos/aarch64

Reviewed-by: burban

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 4, 2022

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2022

Going to push as commit afb94ae.
Since your change was applied there have been 4 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2022
@openjdk openjdk bot closed this Feb 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2022
@openjdk
Copy link

openjdk bot commented Feb 8, 2022

@VladimirKempik Pushed as commit afb94ae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants