Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216969: ParseException thrown for certain months with russian locale #809

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Feb 8, 2022

I think this is a useful, safe fix for 11.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8216969: ParseException thrown for certain months with russian locale

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/809/head:pull/809
$ git checkout pull/809

Update a local copy of the PR:
$ git checkout pull/809
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/809/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 809

View PR using the GUI difftool:
$ git pr show -t 809

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/809.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 8, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0623444ae5a0bbf143c288c7ae2eb2fd5a4ca7ae 8216969: ParseException thrown for certain months with russian locale Feb 8, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 8, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8216969: ParseException thrown for certain months with russian locale

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 8, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 8, 2022

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Feb 9, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2022

Going to push as commit cd7d8c6.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 288c9f7: 8278381: [GCC 11] Address::make_raw() does not initialize rspec
  • afb94ae: 8264650: Cross-compilation to macos/aarch64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 9, 2022
@openjdk openjdk bot closed this Feb 9, 2022
@openjdk openjdk bot removed ready rfr labels Feb 9, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Feb 9, 2022

@GoeLin Pushed as commit cd7d8c6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant