8241004: NMT tests fail on unaligned thread size with debug build

[ahmedmuhsin]

Backport of JDK-8241004. Applies cleanly.

This is will prevent hotspot runtime/NMT test failures on mac-aarch64. See issue 2 in this comment for more context: #715 (comment)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8241004: NMT tests fail on unaligned thread size with debug build

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/812/head:pull/812
$ git checkout pull/812

Update a local copy of the PR:
$ git checkout pull/812
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/812/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 812

View PR using the GUI difftool:
$ git pr show -t 812

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/812.diff

[bridgekeeper]

Hi @ahmedmuhsin, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user ahmedmuhsin" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[ahmedmuhsin]

/covered

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

@ahmedmuhsin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241004: NMT tests fail on unaligned thread size with debug build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
• fe17b44: 8280414: Memory leak in DefaultProxySelector
• fd7d0d3: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
• bd420d2: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
• 29eb422: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter
• d79e710: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801
• 6c26ba2: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently
• f4e14a6: 8281061: [s390] JFR runs into assertions while validating interpreter frames
• 668c200: 8280155: [PPC64, s390] frame size checks are not yet correct
• 6921496: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
• ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/288c9f7d6ac6057216d3c7756ea667cfb65fc6a3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (1c225a86)

[GoeLin]

@ahmedmuhsin should this be integrated as the aarch port was pushed?

[ahmedmuhsin]

@GoeLin Yes, it should. Thanks.

[ahmedmuhsin]

I will need a couple of reviewers.

@VladimirKempik @lewurm,
If you don't mind, can you review this PR?

[VladimirKempik]

You don't. Your backport is a clean backport, you have "clean" label on this PR. So You don't need review for this.

[ahmedmuhsin]

/integrate

[openjdk]

@ahmedmuhsin
Your change (at version 1c225a8) is now ready to be sponsored by a Committer.

[GoeLin]

/sponsor

I don't tag jdk17u-fix-yes if it is not ready :) That is what you have to check once you have the "ready" label.

[openjdk]

Going to push as commit aa42c4d.
Since your change was applied there have been 13 commits pushed to the master branch:

• eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
• fe17b44: 8280414: Memory leak in DefaultProxySelector
• fd7d0d3: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
• bd420d2: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
• 29eb422: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter
• d79e710: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801
• 6c26ba2: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently
• f4e14a6: 8281061: [s390] JFR runs into assertions while validating interpreter frames
• 668c200: 8280155: [PPC64, s390] frame size checks are not yet correct
• 6921496: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
• ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/288c9f7d6ac6057216d3c7756ea667cfb65fc6a3...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin @ahmedmuhsin Pushed as commit aa42c4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.