Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter #813

Closed
wants to merge 1 commit into from

Conversation

D-D-H
Copy link

@D-D-H D-D-H commented Feb 9, 2022

Hi team,

Could I have a review of this fix?

The following code(jfrTypeSet.cpp:L388) passes a wrong parameter _artifacts to the constructor of LeakKlassWriter:

 387 } else {
 388 LeakKlassWriter lkw(_leakp_writer, _artifacts, _class_unload);
 389 CompositeKlassWriter ckw(&lkw, &kw);
 390 CompositeKlassWriterRegistration ckwr(&ckw, &reg);
 391 CompositeKlassCallback callback(&ckwr);
 392 _subsystem_callback = &callback;
 393 do_klasses();
 394 }

This problem is introduced by JDK-8225797 and fixed by JDK-8233111.

I filed a new issue to fix it since I think backporting JDK-8233111 is not necessary for the moment.

testing: test/jdk/jdk/jfr

Thanks,
Denghui


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/813/head:pull/813
$ git checkout pull/813

Update a local copy of the PR:
$ git checkout pull/813
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/813/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 813

View PR using the GUI difftool:
$ git pr show -t 813

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/813.diff

@D-D-H D-D-H changed the title JFR: A wrong parameter is passed to the constructor of LeakKlassWriter 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter Feb 9, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2022

👋 Welcome back ddong! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Feb 9, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@D-D-H This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • d79e710: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801
  • 6c26ba2: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently
  • f4e14a6: 8281061: [s390] JFR runs into assertions while validating interpreter frames
  • 668c200: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 6921496: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 1db4ed1: 8261205: AssertionError: Cannot add metadata to an intersection type
  • 18a0883: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cd7d8c6: 8216969: ParseException thrown for certain months with russian locale

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Feb 9, 2022
@D-D-H
Copy link
Author

D-D-H commented Feb 10, 2022

@phohensee
Thank you for the review.

Is it need a second review? If not, could you help sponsor it?

@phohensee
Copy link
Member

phohensee commented Feb 10, 2022

No need for another review, but you have to go through the usual process of tagging the issue, adding a Fix Request comment, and getting it approved before I can sponsor it.

@D-D-H
Copy link
Author

D-D-H commented Feb 10, 2022

Okay, thanks.

@GoeLin
Copy link
Member

GoeLin commented Feb 10, 2022

@D-D-H
Please follow the instructions for backports: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix
See point 6. You should only add the tag after writing the corresponding comment in the JBS issue.

@D-D-H
Copy link
Author

D-D-H commented Feb 10, 2022

Hi @GoeLin ,

Thanks for the reminder.
But this fix is a new issue rather than a backport, do I still need to add a comment?

And I found an issue(JDK-8277815) of 11u, it is also not a backport, and there is no "Fix request" comment. So, I'm not very sure...

@GoeLin
Copy link
Member

GoeLin commented Feb 10, 2022

@D-D-H
yes, please.
Any change that goes to jdk11u-dev needs a jdk11u-fix-yes by the maintainers.
The comment is the information we need to make a profound decision. It is your
way to address the maintainers. The PR text addresses the reviewers (if you need any).
Maybe I need to improve the documentation, I'll have a look. -- I checked, it expliciely says
that for new fixes you need to follow the steps starting at 3.

@D-D-H
Copy link
Author

D-D-H commented Feb 10, 2022

@GoeLin ,
Thanks, "Fix Request" is added.

@D-D-H
Copy link
Author

D-D-H commented Feb 11, 2022

No need for another review, but you have to go through the usual process of tagging the issue, adding a Fix Request comment, and getting it approved before I can sponsor it.

Got approved, please help sponsor it when you have time, thanks in advance!

@phohensee
Copy link
Member

phohensee commented Feb 11, 2022

Please add a "/integrate" comment. Then I can sponsor it.

@D-D-H
Copy link
Author

D-D-H commented Feb 11, 2022

/integrate

@openjdk openjdk bot added the sponsor label Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@D-D-H
Your change (at version af1544e) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

phohensee commented Feb 11, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 11, 2022

Going to push as commit 29eb422.
Since your change was applied there have been 8 commits pushed to the master branch:

  • d79e710: 8281599: test/lib/jdk/test/lib/KnownOIDs.java is redundant since JDK-8268801
  • 6c26ba2: 8190748: java/text/Format/DateFormat/DateFormatTest.java and NonGregorianFormatTest fail intermittently
  • f4e14a6: 8281061: [s390] JFR runs into assertions while validating interpreter frames
  • 668c200: 8280155: [PPC64, s390] frame size checks are not yet correct
  • 6921496: 8279924: [PPC64, s390] implement frame::is_interpreted_frame_valid checks
  • 1db4ed1: 8261205: AssertionError: Cannot add metadata to an intersection type
  • 18a0883: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cd7d8c6: 8216969: ParseException thrown for certain months with russian locale

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Feb 11, 2022
@openjdk openjdk bot closed this Feb 11, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

@phohensee @D-D-H Pushed as commit 29eb422.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants