Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted #815

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Feb 9, 2022

A clean, test only backport for parity with Oracle 11.0.16.

The test passed on Windows 10.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/815/head:pull/815
$ git checkout pull/815

Update a local copy of the PR:
$ git checkout pull/815
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/815/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 815

View PR using the GUI difftool:
$ git pr show -t 815

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/815.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aaedac635a0a7ca1f73dcf85336230cc537fcdf2 8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted Feb 9, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 9, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265261: java/nio/file/Files/InterruptCopy.java fails with java.lang.RuntimeException: Copy was not interrupted

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 18a0883: 8277992: Add fast jdk_svc subtests to jdk:tier3
  • cd7d8c6: 8216969: ParseException thrown for certain months with russian locale

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 9, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Feb 24, 2022

@zhengyu123 you might want to integrate this before March 1st? Similar the 17u backport.

@zhengyu123
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 22, 2022

Going to push as commit 03da67b.
Since your change was applied there have been 102 commits pushed to the master branch:

  • 9714b69: 8206330: Revisit com/sun/jdi/RedefineCrossEvent.java
  • d568fc8: 8283420: [AOT] Exclude TrackedFlagTest/NotTrackedFlagTest in 11u because of intermittent java.lang.AssertionError: duplicate classes for name Ljava/lang/Boolean;
  • bb54eeb: 8209883: ZGC: Compile without C1 broken
  • 6e5000f: 8283424: compiler/loopopts/LoopUnswitchingBadNodeBudget.java fails with release VMs due to lack of -XX:+UnlockDiagnosticVMOptions
  • cf52a6f: 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream
  • f14b932: 8246494: introduce vm.flagless at-requires property
  • e66e3e5: 8210108: sun/tools/jstatd test build failures after JDK-8210022
  • dd6ba08: 8210649: AssertionError @ jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:244)
  • e6f8c1e: 8240734: ModuleHashes attribute not reproducible between builds
  • 23af0b1: 8230865: [TESTBUG] jdk/jfr/event/io/EvilInstrument.java fails at-run shell MakeJAR.sh target
  • ... and 92 more: https://git.openjdk.java.net/jdk11u-dev/compare/288c9f7d6ac6057216d3c7756ea667cfb65fc6a3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 22, 2022
@openjdk openjdk bot closed this Mar 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 22, 2022
@openjdk
Copy link

openjdk bot commented Mar 22, 2022

@zhengyu123 Pushed as commit 03da67b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants