Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 #816

Closed
wants to merge 15 commits into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Feb 9, 2022

Pleas review this backport to jdk11u-dev.
It's one of few follow up fixes for jep-391 backport.
This adds missing WX transition to jni_DestroyJavaVM_inner and jni_DetachCurrentThread
Not applying clean due to context code difference in chunk 2.
In JDK17 it's - ThreadStateTransition::transition()
in JDK11 it's - ThreadStateTransition::transition_and_fence()


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/816/head:pull/816
$ git checkout pull/816

Update a local copy of the PR:
$ git checkout pull/816
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/816/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 816

View PR using the GUI difftool:
$ git pr show -t 816

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/816.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 9, 2022

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into pr/715 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8a4a9117f5e615080c9530ad0ab1a90852bbc854 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2 Feb 9, 2022
@openjdk
Copy link

openjdk bot commented Feb 9, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Feb 9, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 9, 2022

Webrevs

Copy link
Contributor

@adinn adinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/715 to master February 15, 2022 14:13
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8253795
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2

Reviewed-by: adinn, burban

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Feb 15, 2022

⚠️ @VladimirKempik This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 15, 2022
@openjdk openjdk bot added the clean label Feb 15, 2022
@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

Going to push as commit 0aa5f75.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2022
@openjdk openjdk bot closed this Feb 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@VladimirKempik VladimirKempik deleted the JDK-8262894 branch February 16, 2022 08:30
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@VladimirKempik Pushed as commit 0aa5f75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants