Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} #820

Closed
wants to merge 3 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Feb 11, 2022

Follow up to JDK-8279076 backport.

Additional testing:

  • The test from JDK-8279076 still passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/820/head:pull/820
$ git checkout pull/820

Update a local copy of the PR:
$ git checkout pull/820
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 820

View PR using the GUI difftool:
$ git pr show -t 820

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/820.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/819 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a24f44d17de586c72c8343f8891e72ad8a514597 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1} Feb 11, 2022
@openjdk
Copy link

openjdk bot commented Feb 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Feb 11, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/819 to master February 14, 2022 08:40
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8279076-x86_32-sqrtf
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 14, 2022
@openjdk openjdk bot added the clean label Feb 14, 2022
@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Feb 14, 2022

Going to push as commit fd7d0d3.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 14, 2022
@openjdk openjdk bot closed this Feb 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 14, 2022
@openjdk
Copy link

openjdk bot commented Feb 14, 2022

@shipilev Pushed as commit fd7d0d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8280526-x86-regr branch April 6, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants