8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

[gnu-andrew]

Hi all,

This pull request contains a backport of commit d1aeca11 from the openjdk/jdk repository.

The commit being backported was authored by Brian Burkhalter on 27 Aug 2021 and was reviewed by Joe Darcy.
It has already been backported to jdk17u-dev.

This is a clean backport to 11u. As @shipilev notes on the bug, the original code (JDK-8200659) was backported to all active branches in the January 2019 security update, so we should update the test everywhere as well.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/822/head:pull/822
$ git checkout pull/822

Update a local copy of the PR:
$ git checkout pull/822
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 822

View PR using the GUI difftool:
$ git pr show -t 822

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/822.diff

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (eaa8e158)

[gnu-andrew]

/integrate

[openjdk]

Going to push as commit d6bf0d1.
Since your change was applied there have been 6 commits pushed to the master branch:

• b5f8c31: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
• 0aa5f75: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
• 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
• aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build
• eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
• fe17b44: 8280414: Memory leak in DefaultProxySelector

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit d6bf0d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.