-
Notifications
You must be signed in to change notification settings - Fork 240
8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into |
Webrevs
|
Thanks for addressing this issue! Also, please enable your github actions. |
|
Thank you for your advice. |
Hi, sure, take your time. |
This backport pull request has now been updated with issue from the original commit. |
@yukikimmura This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
@yukikimmura |
/sponsor |
Going to push as commit e2f792c.
Your commit was automatically rebased without conflicts. |
@GoeLin @yukikimmura Pushed as commit e2f792c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale.
Original patch applies cleanly to 11u.
Testing:
build on Windows x86_64 and Linux x86_64
tier1 on Windows x86_64 and Linux x86_64
a specific test to confirm the fix in Japanese locale
Could you please review this PR?
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/824/head:pull/824
$ git checkout pull/824
Update a local copy of the PR:
$ git checkout pull/824
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/824/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 824
View PR using the GUI difftool:
$ git pr show -t 824
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/824.diff