Skip to content

8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

yukikimmura
Copy link
Member

@yukikimmura yukikimmura commented Feb 15, 2022

This is a backport of JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale.
Original patch applies cleanly to 11u.

Testing:
build on Windows x86_64 and Linux x86_64
tier1 on Windows x86_64 and Linux x86_64
a specific test to confirm the fix in Japanese locale

Could you please review this PR?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/824/head:pull/824
$ git checkout pull/824

Update a local copy of the PR:
$ git checkout pull/824
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/824/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 824

View PR using the GUI difftool:
$ git pr show -t 824

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/824.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Feb 15, 2022

Thanks for addressing this issue!
If this is actually clean, you did something wrong because skara should mark it as clean. And if so, no review is needed. Please change the title to "Backport ". This has the same effect as the commit message in Step 2 Option 3 e. in https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix

Also, please enable your github actions.

@yukikimmura yukikimmura changed the title 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale Backport dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

⚠️ @yukikimmura could not find any commit with hash dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f. Please update the title with the hash for an existing commit.

@yukikimmura
Copy link
Member Author

Thank you for your advice.
I used Option 3 in Step 2.
This is my first contribution.
I would appreciate it if you could give me some time to check the flow.

@GoeLin
Copy link
Member

GoeLin commented Feb 15, 2022

Hi, sure, take your time.
It needs to be the hash of the existing commit: b46d73b (the full, not the abbreviated. GitHub abbreviates it)
(If there are several existing commits, e.g. for 19 and 17.0.3, you can choose either.)

@yukikimmura yukikimmura changed the title Backport dcd8f03c06f0ca2b87c73a259f2ec1e9fdac258f Backport b46d73bee808af7891b699df30a5a6dec3f5139f Feb 16, 2022
@openjdk openjdk bot changed the title Backport b46d73bee808af7891b699df30a5a6dec3f5139f 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • d6bf0d1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • b5f8c31: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
  • 0aa5f75: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build
  • eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
  • fe17b44: 8280414: Memory leak in DefaultProxySelector
  • fd7d0d3: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • bd420d2: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 29eb422: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter
  • ... and 14 more: https://git.openjdk.java.net/jdk11u-dev/compare/01c38c4ffa1f408061caee9aed2e4e863d01207f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

⚠️ @yukikimmura This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@yukikimmura
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@yukikimmura
Your change (at version 895a497) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Feb 17, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 17, 2022

Going to push as commit e2f792c.
Since your change was applied there have been 24 commits pushed to the master branch:

  • d6bf0d1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • b5f8c31: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
  • 0aa5f75: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build
  • eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
  • fe17b44: 8280414: Memory leak in DefaultProxySelector
  • fd7d0d3: 8280526: x86_32 Math.sqrt performance regression with -XX:UseSSE={0,1}
  • bd420d2: 8279076: C2: Bad AD file when matching SqrtF with UseSSE=0
  • 29eb422: 8281520: JFR: A wrong parameter is passed to the constructor of LeakKlassWriter
  • ... and 14 more: https://git.openjdk.java.net/jdk11u-dev/compare/01c38c4ffa1f408061caee9aed2e4e863d01207f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2022
@openjdk openjdk bot closed this Feb 17, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@GoeLin @yukikimmura Pushed as commit e2f792c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants