Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263856: Github Actions for macos/aarch64 cross-build #826

Closed
wants to merge 3 commits into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Feb 15, 2022

PLease review this backport to jdk11u-dev
it enables github CI crossbuilds of macos-aarch64
Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263856: Github Actions for macos/aarch64 cross-build

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/826/head:pull/826
$ git checkout pull/826

Update a local copy of the PR:
$ git checkout pull/826
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/826/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 826

View PR using the GUI difftool:
$ git pr show -t 826

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/826.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into pr/810 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 114e3c3e2daedb34368c741bc8902f532550043f 8263856: Github Actions for macos/aarch64 cross-build Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 15, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/810 to master March 2, 2022 15:30
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8260518
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263856: Github Actions for macos/aarch64 cross-build

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 5561fd1: 8260518: Change default -mmacosx-version-min to 10.12
  • 16d98b3: 8282501: Bump update version for OpenJDK: jdk-11.0.16
  • 5cad68f: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider
  • c0effc2: 8211333: AArch64: Fix another build failure after JDK-8211029
  • 80919eb: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
  • ba6c4c1: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
  • 80a2777: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous
  • 68c6320: 8214004: Missing space between compiler thread name and task info in hs_err
  • 16cbd32: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols
  • 6f9d287: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/eb0708f75aa3c196e41014addfaa5667fd940cc2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 2, 2022
@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

Going to push as commit 8a9f20a.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 5561fd1: 8260518: Change default -mmacosx-version-min to 10.12
  • 16d98b3: 8282501: Bump update version for OpenJDK: jdk-11.0.16
  • 5cad68f: 8255410: Add ChaCha20 and Poly1305 support to SunPKCS11 provider
  • c0effc2: 8211333: AArch64: Fix another build failure after JDK-8211029
  • 80919eb: 8279669: test/jdk/com/sun/jdi/TestScaffold.java uses wrong condition
  • ba6c4c1: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
  • 80a2777: 8282372: [11] build issue on MacOS/aarch64 12.2.1 using Xcode 13.1: call to 'log2_intptr' is ambiguous
  • 68c6320: 8214004: Missing space between compiler thread name and task info in hs_err
  • 16cbd32: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols
  • 6f9d287: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • ... and 11 more: https://git.openjdk.java.net/jdk11u-dev/compare/eb0708f75aa3c196e41014addfaa5667fd940cc2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2022
@openjdk openjdk bot closed this Mar 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@VladimirKempik Pushed as commit 8a9f20a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants