New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263856: Github Actions for macos/aarch64 cross-build #826
Conversation
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8260518
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 21 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8a9f20a.
Your commit was automatically rebased without conflicts. |
@VladimirKempik Pushed as commit 8a9f20a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
PLease review this backport to jdk11u-dev
it enables github CI crossbuilds of macos-aarch64
Not applying clean due to gtest and few configure options, remade the patch basing on macos-intel part of existing jdk11u-dev job
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/826/head:pull/826
$ git checkout pull/826
Update a local copy of the PR:
$ git checkout pull/826
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/826/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 826
View PR using the GUI difftool:
$ git pr show -t 826
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/826.diff