Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247589: Implementation of Alpine Linux/x64 Port #827

Closed
wants to merge 2 commits into from

Conversation

yftsai
Copy link
Contributor

@yftsai yftsai commented Feb 15, 2022

Other commits relating to Alpine Linux/x86 Port are included.

2845c3d 8245938: Remove unused print_stack(void) method from XToolkit.c
5490b03 8252248: __SIGRTMAX is not declared in musl libc
b957d80 8252250: isnanf is obsolete

The following commit is not included, but related change in jdk_util_md.h is added.

993b1b0 8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/827/head:pull/827
$ git checkout pull/827

Update a local copy of the PR:
$ git checkout pull/827
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/827/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 827

View PR using the GUI difftool:
$ git pr show -t 827

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/827.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 15, 2022

👋 Welcome back yftsai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 63009f90ec7df053c936226663b463b8584364a9 8247589: Implementation of Alpine Linux/x64 Port Feb 15, 2022
@openjdk
Copy link

openjdk bot commented Feb 15, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 15, 2022
@yftsai yftsai marked this pull request as ready for review February 16, 2022 06:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

@yftsai
Copy link
Contributor Author

yftsai commented Feb 16, 2022

Bellsoft plans to propose a backport. This PR is withdrawn in favor of the plan.

@yftsai yftsai closed this Feb 16, 2022
@yftsai yftsai deleted the 8247589-alpine branch February 16, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant