Skip to content

Conversation

@yukikimmura
Copy link
Member

@yukikimmura yukikimmura commented Feb 17, 2022

This is a backport of JDK-8254085:javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
TestCaretPositionJTextPane.java fails also in jdk11, so needs to be fixed.

This is a clean backport to 11u. I confirmed this test passed after this backport. 
Testing:
build on Windows x86_64 and Linux x86_64
tier1 on Windows x86_64 and Linux x86_64


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/829/head:pull/829
$ git checkout pull/829

Update a local copy of the PR:
$ git checkout pull/829
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 829

View PR using the GUI difftool:
$ git pr show -t 829

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/829.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 51a865d66a5dddbbaaa4bb656fa02ecd1bee1a0b 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException:  Wrong caret position"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 57003ee: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • e2f792c: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
  • d6bf0d1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • b5f8c31: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
  • 0aa5f75: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build
  • eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
  • fe17b44: 8280414: Memory leak in DefaultProxySelector

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 17, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

@yukikimmura
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

@yukikimmura
Your change (at version 54e63ce) is now ready to be sponsored by a Committer.

@yukikimmura
Copy link
Member Author

I would appliciate it if someone could sponsor the fix.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

Going to push as commit 4378844.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 26e599d: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail
  • 259bbf5: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64
  • 57003ee: 8274524: SSLSocket.close() hangs if it is called during the ssl handshake
  • e2f792c: 8255239: The timezone of the hs_err_pid log file is corrupted in Japanese locale
  • d6bf0d1: 8272541: Incorrect overflow test in Toom-Cook branch of BigInteger multiplication
  • b5f8c31: 8254072: AArch64: Get rid of --disable-warnings-as-errors on Windows+ARM64 build
  • 0aa5f75: 8262894: [macos_aarch64] SIGBUS in Assembler::ld_st2
  • 69583df: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • aa42c4d: 8241004: NMT tests fail on unaligned thread size with debug build
  • eb0708f: 8253795: Implementation of JEP 391: macOS/AArch64 Port
  • ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/fd7d0d3d687729ffe46839f5a47e85ba09ad4501...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2022
@openjdk openjdk bot closed this Feb 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@phohensee @yukikimmura Pushed as commit 4378844.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants