-
Notifications
You must be signed in to change notification settings - Fork 252
8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position" #829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@yukikimmura This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@yukikimmura |
|
I would appliciate it if someone could sponsor the fix. |
|
/sponsor |
|
Going to push as commit 4378844.
Your commit was automatically rebased without conflicts. |
|
@phohensee @yukikimmura Pushed as commit 4378844. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a backport of JDK-8254085:javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
TestCaretPositionJTextPane.java fails also in jdk11, so needs to be fixed.
This is a clean backport to 11u. I confirmed this test passed after this backport.
Testing:
build on Windows x86_64 and Linux x86_64
tier1 on Windows x86_64 and Linux x86_64
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/829/head:pull/829$ git checkout pull/829Update a local copy of the PR:
$ git checkout pull/829$ git pull https://git.openjdk.java.net/jdk11u-dev pull/829/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 829View PR using the GUI difftool:
$ git pr show -t 829Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/829.diff