8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

tstuefe · 2021-06-30T12:35:01Z

I would like to backport this change to JDK-11 since this flag helps us analyzing metaspace problems, and beyond that its completely harmless.

The original patch does not properly apply, since the flag definition format in globals.hpp has changed since JDK11. Other than that, the patch is trivial.

Nightlies at SAP ran through with this patch for several weeks now.

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed

Issue

JDK-8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

Reviewers

Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/83.diff

bridgekeeper · 2021-06-30T12:36:20Z

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2021-06-30T12:36:54Z

This backport pull request has now been updated with issue from the original commit.

RealCLanger · 2021-09-08T20:32:40Z

Hi, @tstuefe. Any updates on this one?

tstuefe · 2021-09-09T06:50:39Z

Hi, @tstuefe. Any updates on this one?

Its on my list..

tstuefe · 2021-09-15T08:06:38Z

/label jdk-updates-dev

openjdk · 2021-09-15T08:07:11Z

@tstuefe The label jdk-updates is not a valid label. These labels are valid:

mlbridge · 2021-09-15T08:07:11Z

Webrevs

RealCLanger

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.

Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

RealCLanger · 2021-09-15T20:49:27Z

src/hotspot/share/runtime/globals.hpp

@@ -1824,6 +1824,10 @@ define_pd_global(uint64_t,MaxRAM,                    1ULL*G);
          "class pointers are used")                                        \
          range(1*M, 3*G)                                                   \
                                                                            \
+  diagnostic(bool, PrintMetaspaceStatisticsAtExit, false,                   \
+                  "Print metaspace statistics upon VM exit.")               \


Could you fix the indentation of this line to match the formatting for the other flags around here?

RealCLanger · 2021-09-15T20:49:27Z

src/hotspot/share/runtime/globals.hpp

+  diagnostic(bool, PrintMetaspaceStatisticsAtExit, false,                   \
+                  "Print metaspace statistics upon VM exit.")               \
+                                                                            \
+                                                                            \


one empty line is enough, I'd say.

tstuefe · 2021-09-16T04:50:01Z

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.

Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

RealCLanger · 2021-09-16T05:27:25Z

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.
Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

Sure, LGTM now 👍

openjdk · 2021-09-16T05:28:52Z

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

tstuefe · 2021-09-16T06:22:34Z

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.
Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

Sure, LGTM now

Thanks. I'll wait for the GHAs to finish, then push.

tstuefe · 2021-09-16T06:56:24Z

/integrate

openjdk · 2021-09-16T06:58:28Z

Going to push as commit 263d070.

openjdk · 2021-09-16T06:58:43Z

@tstuefe Pushed as commit 263d070.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot changed the title ~~Backport ddd2951ba91fe3860b92d2f9bad4e0d900f1d650~~ 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit Jun 30, 2021

openjdk bot added the backport label Jun 30, 2021

Backport ddd2951

ca08723

tstuefe force-pushed the tstuefe-backport-ddd2951b branch from 4902dc5 to ca08723 Compare Sep 15, 2021

tstuefe marked this pull request as ready for review Sep 15, 2021

openjdk bot added the rfr label Sep 15, 2021

RealCLanger suggested changes Sep 15, 2021

View changes

tstuefe added 2 commits Sep 16, 2021

Merge

cbd51f0

Format changes

f4532a2

RealCLanger approved these changes Sep 16, 2021

View changes

openjdk bot added the ready label Sep 16, 2021

openjdk bot closed this Sep 16, 2021

openjdk bot added integrated and removed ready rfr labels Sep 16, 2021

tstuefe deleted the tstuefe-backport-ddd2951b branch Nov 5, 2021

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

tstuefe commented Jun 30, 2021 •

edited by openjdk[bot] bot

bridgekeeper bot commented Jun 30, 2021

openjdk bot commented Jun 30, 2021

RealCLanger commented Sep 8, 2021

tstuefe commented Sep 9, 2021

tstuefe commented Sep 15, 2021

openjdk bot commented Sep 15, 2021

mlbridge bot commented Sep 15, 2021 •

edited

RealCLanger left a comment

RealCLanger Sep 15, 2021

RealCLanger Sep 15, 2021

tstuefe commented Sep 16, 2021

RealCLanger commented Sep 16, 2021

openjdk bot commented Sep 16, 2021 •

edited

tstuefe commented Sep 16, 2021

tstuefe commented Sep 16, 2021

openjdk bot commented Sep 16, 2021

openjdk bot commented Sep 16, 2021

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

Conversation

tstuefe commented Jun 30, 2021 • edited by openjdk[bot] bot

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jun 30, 2021

openjdk bot commented Jun 30, 2021

RealCLanger commented Sep 8, 2021

tstuefe commented Sep 9, 2021

tstuefe commented Sep 15, 2021

openjdk bot commented Sep 15, 2021

mlbridge bot commented Sep 15, 2021 • edited

Webrevs

RealCLanger left a comment

RealCLanger Sep 15, 2021

Choose a reason for hiding this comment

RealCLanger Sep 15, 2021

Choose a reason for hiding this comment

tstuefe commented Sep 16, 2021

RealCLanger commented Sep 16, 2021

openjdk bot commented Sep 16, 2021 • edited

tstuefe commented Sep 16, 2021

tstuefe commented Sep 16, 2021

openjdk bot commented Sep 16, 2021

openjdk bot commented Sep 16, 2021

tstuefe commented Jun 30, 2021 •

edited by openjdk[bot] bot

mlbridge bot commented Sep 15, 2021 •

edited

openjdk bot commented Sep 16, 2021 •

edited