Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit #83

Closed
wants to merge 3 commits into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jun 30, 2021

I would like to backport this change to JDK-11 since this flag helps us analyzing metaspace problems, and beyond that its completely harmless.

The original patch does not properly apply, since the flag definition format in globals.hpp has changed since JDK11. Other than that, the patch is trivial.

Nightlies at SAP ran through with this patch for several weeks now.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/83/head:pull/83
$ git checkout pull/83

Update a local copy of the PR:
$ git checkout pull/83
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/83/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 83

View PR using the GUI difftool:
$ git pr show -t 83

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/83.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2021

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ddd2951ba91fe3860b92d2f9bad4e0d900f1d650 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 30, 2021
@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 8, 2021

Hi, @tstuefe. Any updates on this one?

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 9, 2021

Hi, @tstuefe. Any updates on this one?

Its on my list..

@tstuefe tstuefe force-pushed the tstuefe-backport-ddd2951b branch from 4902dc5 to ca08723 Compare Sep 15, 2021
@tstuefe tstuefe marked this pull request as ready for review Sep 15, 2021
@openjdk openjdk bot added the rfr label Sep 15, 2021
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 15, 2021

/label jdk-updates-dev

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@tstuefe The label jdk-updates is not a valid label. These labels are valid:

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.

Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

@@ -1824,6 +1824,10 @@ define_pd_global(uint64_t,MaxRAM, 1ULL*G);
"class pointers are used") \
range(1*M, 3*G) \
\
diagnostic(bool, PrintMetaspaceStatisticsAtExit, false, \
"Print metaspace statistics upon VM exit.") \
Copy link
Contributor

@RealCLanger RealCLanger Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the indentation of this line to match the formatting for the other flags around here?

diagnostic(bool, PrintMetaspaceStatisticsAtExit, false, \
"Print metaspace statistics upon VM exit.") \
\
\
Copy link
Contributor

@RealCLanger RealCLanger Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one empty line is enough, I'd say.

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 16, 2021

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.

Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 16, 2021

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.
Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

Sure, LGTM now 👍

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@tstuefe This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2021
@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 16, 2021

Overall looks good, I just have two formatting remarks which IMHO should be cleaned up.
Other than that, maybe you could enable Github Actions on your repository to get a test run after your next push.

Thanks Christoph. GHAs enabled, format changes done. Note that the patch cooked in our internal systems for about two months now, so I don't expect surprises.

Sure, LGTM now

Thanks. I'll wait for the GHAs to finish, then push.

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Sep 16, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit 263d070.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@tstuefe Pushed as commit 263d070.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the tstuefe-backport-ddd2951b branch Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants