New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8214004: Missing space between compiler thread name and task info in hs_err #831
Conversation
|
Could anyone review the fix please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@yukikimmura This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.
|
Thank you for your review, phohensee. /integrate |
@yukikimmura |
/sponsor |
Going to push as commit 68c6320.
Your commit was automatically rebased without conflicts. |
@phohensee @yukikimmura Pushed as commit 68c6320. |
I'd like to backport JDK-8214004.
The original patch does not applies cleanly because JDK-8163511 was applied first in 11u.
The change only reflects JDK-8163511 on the following line, and there is no risk.
I tested tier1 with rhel and windows x86_64, and no errors found.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/831/head:pull/831
$ git checkout pull/831
Update a local copy of the PR:
$ git checkout pull/831
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/831/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 831
View PR using the GUI difftool:
$ git pr show -t 831
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/831.diff