Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8214004: Missing space between compiler thread name and task info in hs_err #831

Closed
wants to merge 2 commits into from
Closed

Conversation

yukikimmura
Copy link
Contributor

@yukikimmura yukikimmura commented Feb 18, 2022

I'd like to backport JDK-8214004.
The original patch does not applies cleanly because JDK-8163511 was applied first in 11u.

The change only reflects JDK-8163511 on the following line, and there is no risk.
I tested tier1 with rhel and windows x86_64, and no errors found.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8214004: Missing space between compiler thread name and task info in hs_err ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/831/head:pull/831
$ git checkout pull/831

Update a local copy of the PR:
$ git checkout pull/831
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/831/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 831

View PR using the GUI difftool:
$ git pr show -t 831

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/831.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2022

👋 Welcome back yukikimmura! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 18, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2022

Webrevs

@yukikimmura
Copy link
Contributor Author

Could anyone review the fix please?

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@yukikimmura This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8214004: Missing space between compiler thread name and task info in hs_err

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 16cbd32: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols
  • 6f9d287: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • ffa5ae8: 8247515: OSX pc_to_symbol() lookup does not work with core files
  • 4378844: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • 26e599d: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail
  • 259bbf5: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 22, 2022
@yukikimmura
Copy link
Contributor Author

Thank you for your review, phohensee.

/integrate
I would appliciate it if someone could sponsor the fix.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 24, 2022
@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@yukikimmura
Your change (at version 8d36cce) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 24, 2022

Going to push as commit 68c6320.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 16cbd32: 8250750: JDK-8247515 fix for OSX pc_to_symbol() lookup fails with some symbols
  • 6f9d287: 8277488: Add expiry exception for Digicert (geotrustglobalca) expiring in May 2022
  • ffa5ae8: 8247515: OSX pc_to_symbol() lookup does not work with core files
  • 4378844: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • 26e599d: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail
  • 259bbf5: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 24, 2022
@openjdk openjdk bot closed this Feb 24, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 24, 2022
@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@phohensee @yukikimmura Pushed as commit 68c6320.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants