Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247515: OSX pc_to_symbol() lookup does not work with core files #832

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 18, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247515: OSX pc_to_symbol() lookup does not work with core files

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/832/head:pull/832
$ git checkout pull/832

Update a local copy of the PR:
$ git checkout pull/832
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 832

View PR using the GUI difftool:
$ git pr show -t 832

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/832.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ab729d7075d718b146b643d1b4c2735adaeb7194 8247515: OSX pc_to_symbol() lookup does not work with core files Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Feb 18, 2022
@MBaesken
Copy link
Member Author

/clean

@openjdk openjdk bot added rfr Pull request is ready for review clean labels Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@MBaesken This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8247515: OSX pc_to_symbol() lookup does not work with core files

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 18, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2022

Webrevs

@RealCLanger
Copy link
Contributor

/clean

Citing from the JBS issue: The patch applies cleanly with the exception of the copyright headers in src/jdk.hotspot.agent/macosx/native/libsaproc/libproc_impl.h:1 and src/jdk.hotspot.agent/macosx/native/libsaproc/ps_core.c:1 which were altered by other backports.

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 23, 2022

Going to push as commit ffa5ae8.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 4378844: 8254085: javax/swing/text/Caret/TestCaretPositionJTextPane.java failed with "RuntimeException: Wrong caret position"
  • 26e599d: 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail
  • 259bbf5: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 23, 2022
@openjdk openjdk bot closed this Feb 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 23, 2022
@openjdk
Copy link

openjdk bot commented Feb 23, 2022

@MBaesken Pushed as commit ffa5ae8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@MBaesken MBaesken deleted the MBaesken-backport-ab729d70 branch March 17, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants