Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail #833

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Feb 18, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/833/head:pull/833
$ git checkout pull/833

Update a local copy of the PR:
$ git checkout pull/833
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/833/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 833

View PR using the GUI difftool:
$ git pr show -t 833

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/833.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 18, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fd206e1e7e2a78203305c6bf94fb2db5e410e7f7 8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail Feb 18, 2022
@openjdk
Copy link

openjdk bot commented Feb 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 18, 2022

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8247272: SA ELF file support has never worked for 64-bit causing address to symbol name mapping to fail

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 18, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 18, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 22, 2022

Going to push as commit 26e599d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 259bbf5: 8233986: ProblemList javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java for windows-x64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 22, 2022
@openjdk openjdk bot closed this Feb 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 22, 2022
@openjdk
Copy link

openjdk bot commented Feb 22, 2022

@MBaesken Pushed as commit 26e599d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant