Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281615: Deadlock caused by jdwp agent #843

Closed
wants to merge 1 commit into from

Conversation

zhengyu123
Copy link
Contributor

@zhengyu123 zhengyu123 commented Feb 28, 2022

I would like to backport this patch to jdk11u, because without the fix, jdwp can potential deadlock whole JVM.

Test:

  • Testbase_nsk_jdi
  • Testbase_nsk_jvmti
  • Testbase_nsk_jdwp

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/843/head:pull/843
$ git checkout pull/843

Update a local copy of the PR:
$ git checkout pull/843
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/843/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 843

View PR using the GUI difftool:
$ git pr show -t 843

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/843.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 28, 2022

👋 Welcome back zgu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e1060bee2adb9f2e07ca09309d0f89132db30f28 8281615: Deadlock caused by jdwp agent Feb 28, 2022
@openjdk
Copy link

openjdk bot commented Feb 28, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Feb 28, 2022

@zhengyu123 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8281615: Deadlock caused by jdwp agent

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ba6c4c1: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Feb 28, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 28, 2022

Webrevs

@zhengyu123
Copy link
Contributor Author

zhengyu123 commented Mar 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 15, 2022

Going to push as commit deb0857.
Since your change was applied there have been 43 commits pushed to the master branch:

  • 1b8ef74: 8266251: compiler.inlining.InlineAccessors shouldn't do testing in driver VM
  • f8abb70: 8231565: More node budget asserts in fuzzed tests
  • 18b5f5b: 8229499: Node budget assert in fuzzed test
  • 6c84ce9: 8234605: C2 failed "assert(C->live_nodes() - live_at_begin <= 2 * _nodes_required) failed: Bad node estimate: actual = 208 >> request = 101"
  • ed275ba: 8246741: NetworkInterface/UniqueMacAddressesTest: mac address uniqueness test failed
  • 2ed46d8: 8211822: Some tests fail after JDK-8210039
  • f441970: 8223389: Shenandoah optimizations fail with assert(!phase->exceeding_node_budget())
  • f3708bb: 8225475: Node budget asserts on x86_32/64
  • 997c55f: 8283018: 11u GHA: Update GCC 9 minor versions
  • c94ce2c: 8210039: move OSInfo to top level testlibrary
  • ... and 33 more: https://git.openjdk.java.net/jdk11u-dev/compare/80a27773cbba61c0cb47de15c48f7fb9ecb69f4a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 15, 2022
@openjdk openjdk bot closed this Mar 15, 2022
@openjdk openjdk bot removed ready rfr labels Mar 15, 2022
@openjdk
Copy link

openjdk bot commented Mar 15, 2022

@zhengyu123 Pushed as commit deb0857.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant