Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211333: AArch64: Fix another build failure after JDK-8211029 #844

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Mar 1, 2022

I backport this to fix the build on windows aarch64. See also #841 (comment)

I had to do trivial resolves due to context. ahmedmuhsin did the same ones.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211333: AArch64: Fix another build failure after JDK-8211029

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/844/head:pull/844
$ git checkout pull/844

Update a local copy of the PR:
$ git checkout pull/844
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/844/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 844

View PR using the GUI difftool:
$ git pr show -t 844

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/844.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 1, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 21af2af13ecc7739b6e28b0a46896108570e564c 8211333: AArch64: Fix another build failure after JDK-8211029 Mar 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 1, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 1, 2022

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2022

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211333: AArch64: Fix another build failure after JDK-8211029

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 1, 2022
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Mar 1, 2022

Thanks for the review!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2022

Going to push as commit c0effc2.

@openjdk openjdk bot added the integrated label Mar 1, 2022
@openjdk openjdk bot closed this Mar 1, 2022
@openjdk openjdk bot removed ready rfr labels Mar 1, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 1, 2022

@GoeLin Pushed as commit c0effc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8211333 branch Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants