Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8217340: Compilation failed: tools/launcher/Test7029048.java #848

Closed
wants to merge 1 commit into from

Conversation

voitylov
Copy link

@voitylov voitylov commented Mar 3, 2022

JDK-8217340 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1].

Original changeset does not apply cleanly because comment line was changed to javadoc-style from "/*" to "/**" as part of "8216265: [testbug] Introduce Platform.sharedLibraryPathVariableName() and adapt all tests", which is irrelevant and too large to backport.

Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions.

[1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8217340: Compilation failed: tools/launcher/Test7029048.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/848/head:pull/848
$ git checkout pull/848

Update a local copy of the PR:
$ git checkout pull/848
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 848

View PR using the GUI difftool:
$ git pr show -t 848

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/848.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2022

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e16b29942039d33cbd1ab15ed0a8154efa7ac55f 8217340: Compilation failed: tools/launcher/Test7029048.java Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@voitylov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8217340: Compilation failed: tools/launcher/Test7029048.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2022

Webrevs

@voitylov
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@voitylov
Your change (at version 9aa8a71) is now ready to be sponsored by a Committer.

@AlexanderScherbatiy
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 7d3db81.
Since your change was applied there have been 20 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@AlexanderScherbatiy @voitylov Pushed as commit 7d3db81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants