Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8252250: isnanf is obsolete #851

Closed
wants to merge 1 commit into from
Closed

Conversation

voitylov
Copy link

@voitylov voitylov commented Mar 3, 2022

JDK-8252250 is in the first batch of a chain of backports for Alpine support to 11u as discussed in the mailing list. For the full set of anticipated changes please refer to the jdk-updates mailing list [1].

Unlike original changeset this backport also changes src/java.base/unix/native/libjava/jdk_util_md.h because it also contains isnanf, which was removed in JDK16 by "JDK-8249612: Remove unused ISNANF and ISNAND from jdk_util_md.h" after removing its usage by "JDK-8199424: consider removing ObjectInputStream and ObjectOutputStream native methods" in JDK14.

Testing: JCK + JTreg on Windows, Linux, Solaris, Mac without regressions.

[1] https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2022-February/012271.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/851/head:pull/851
$ git checkout pull/851

Update a local copy of the PR:
$ git checkout pull/851
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 851

View PR using the GUI difftool:
$ git pr show -t 851

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/851.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 3, 2022

👋 Welcome back avoitylov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b957d802e6982be56d3a344668d8fd230f20d0df 8252250: isnanf is obsolete Mar 3, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 3, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 3, 2022

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 3, 2022

@voitylov This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252250: isnanf is obsolete

Reviewed-by: vkempik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@VladimirKempik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Mar 3, 2022
@voitylov
Copy link
Author

@voitylov voitylov commented Mar 10, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 10, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2022

@voitylov
Your change (at version b2ce099) is now ready to be sponsored by a Committer.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Mar 10, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2022

Going to push as commit 49f9105.
Since your change was applied there have been 17 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 10, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2022

@VladimirKempik @voitylov Pushed as commit 49f9105.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants