-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JDK-8282588: [11] set harfbuzz compilation flag to -std=c++11 #853
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I had added the flag in the same file when creating my experimental JDK-8247872 backport http://cr.openjdk.java.net/~mdoerr/8247872_harfbuzz_11u/
@MBaesken This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 86d39a6. |
As a preparation to update harfbuzz in jdk11u-dev to the versions used in higher JDK (harfbuzz 2.7.2 / 2.8.0) increment the C++ version
for harfbuzz to C++11.
Some time later, the harfbuzz changes are backported.
This gives everybody time to make sure the compilers work with the C++11 flag, or system harfbuzz is used as a workaround.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/853/head:pull/853
$ git checkout pull/853
Update a local copy of the PR:
$ git checkout pull/853
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/853/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 853
View PR using the GUI difftool:
$ git pr show -t 853
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/853.diff