Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211962: Implicit narrowing in MacOSX java.desktop jsound #854

Closed
wants to merge 1 commit into from

Conversation

lewurm
Copy link
Member

@lewurm lewurm commented Mar 4, 2022

Hi all,

This pull request contains a backport of commit 47e7b141 from the openjdk/jdk repository.

The commit being backported was authored by Kim Barrett on 11 Oct 2018 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8211962: Implicit narrowing in MacOSX java.desktop jsound

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/854/head:pull/854
$ git checkout pull/854

Update a local copy of the PR:
$ git checkout pull/854
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/854/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 854

View PR using the GUI difftool:
$ git pr show -t 854

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/854.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 4, 2022

👋 Welcome back burban! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 47e7b141c03b338ef7bbadc3c554e50c8fb210a9 8211962: Implicit narrowing in MacOSX java.desktop jsound Mar 4, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Mar 4, 2022

@lewurm This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211962: Implicit narrowing in MacOSX java.desktop jsound

Cast value to needed type.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • bca1970: 8223143: Restructure/clean-up for 'loopexit_or_null()'.
  • 571d323: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names
  • 87b6007: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region
  • 56e2384: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests
  • 7a1d1e0: Merge
  • 1cff563: 8277795: ldap connection timeout not honoured under contention
  • e339111: 8276141: XPathFactory set/getProperty method
  • b0c0dc5: 8275082: Update XML Security for Java to 2.3.0
  • 4b9bba6: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
  • 86d39a6: 8282588: [11] set harfbuzz compilation flag to -std=c++11

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Mar 4, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 4, 2022

Webrevs

@lewurm
Copy link
Member Author

@lewurm lewurm commented Mar 9, 2022

/integrate

@openjdk openjdk bot added the sponsor label Mar 9, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2022

@lewurm
Your change (at version c36c810) is now ready to be sponsored by a Committer.

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Mar 9, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2022

Going to push as commit 85a89c5.
Since your change was applied there have been 10 commits pushed to the master branch:

  • bca1970: 8223143: Restructure/clean-up for 'loopexit_or_null()'.
  • 571d323: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names
  • 87b6007: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region
  • 56e2384: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests
  • 7a1d1e0: Merge
  • 1cff563: 8277795: ldap connection timeout not honoured under contention
  • e339111: 8276141: XPathFactory set/getProperty method
  • b0c0dc5: 8275082: Update XML Security for Java to 2.3.0
  • 4b9bba6: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
  • 86d39a6: 8282588: [11] set harfbuzz compilation flag to -std=c++11

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 9, 2022
@openjdk openjdk bot closed this Mar 9, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Mar 9, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 9, 2022

@VladimirKempik @lewurm Pushed as commit 85a89c5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants