8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result

[caojoshua]

One rejected hunk on the copyright year:

diff a/src/java.base/share/classes/java/lang/StringCoding.java b/src/java.base/share/classes/java/lang/StringCoding.java        (rejected hunks)
@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2000, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2000, 2021, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it

Otherwise, this is a clean backport.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/860/head:pull/860
$ git checkout pull/860

Update a local copy of the PR:
$ git checkout pull/860
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 860

View PR using the GUI difftool:
$ git pr show -t 860

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/860.diff

[bridgekeeper]

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (61c6d2ff)

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[phohensee]

/clean

[openjdk]

@phohensee This backport pull request is now marked as clean

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 85a89c5: 8211962: Implicit narrowing in MacOSX java.desktop jsound
• bca1970: 8223143: Restructure/clean-up for 'loopexit_or_null()'.
• 571d323: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names
• 87b6007: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region
• 56e2384: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests
• 7a1d1e0: Merge
• 1cff563: 8277795: ldap connection timeout not honoured under contention
• e339111: 8276141: XPathFactory set/getProperty method
• b0c0dc5: 8275082: Update XML Security for Java to 2.3.0
• 4b9bba6: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version 61c6d2f) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 8e01531.
Since your change was applied there have been 10 commits pushed to the master branch:

• 85a89c5: 8211962: Implicit narrowing in MacOSX java.desktop jsound
• bca1970: 8223143: Restructure/clean-up for 'loopexit_or_null()'.
• 571d323: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names
• 87b6007: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region
• 56e2384: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests
• 7a1d1e0: Merge
• 1cff563: 8277795: ldap connection timeout not honoured under contention
• e339111: 8276141: XPathFactory set/getProperty method
• b0c0dc5: 8275082: Update XML Security for Java to 2.3.0
• 4b9bba6: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @caojoshua Pushed as commit 8e01531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.