Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223143: Restructure/clean-up for 'loopexit_or_null()'. #861

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 8, 2022

Clean backport of JDK-8223143.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223143: Restructure/clean-up for 'loopexit_or_null()'.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/861/head:pull/861
$ git checkout pull/861

Update a local copy of the PR:
$ git checkout pull/861
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/861/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 861

View PR using the GUI difftool:
$ git pr show -t 861

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/861.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8088ed83178ef8b0e4be6d510f28bd6bb1beecc8 8223143: Restructure/clean-up for 'loopexit_or_null()'. Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223143: Restructure/clean-up for 'loopexit_or_null()'.

Minor restructure and clean-up for 'loopexit_or_null()' and its use.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 8, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 9, 2022

Going to push as commit bca1970.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 571d323: 8208249: TriggerUnloadingByFillingMetaspace generates garbage class names
  • 87b6007: 8279837: C2: assert(is_Loop()) failed: invalid node class: Region
  • 56e2384: 8208246: flags duplications in vmTestbase_vm_g1classunloading tests
  • 7a1d1e0: Merge
  • 1cff563: 8277795: ldap connection timeout not honoured under contention
  • e339111: 8276141: XPathFactory set/getProperty method
  • b0c0dc5: 8275082: Update XML Security for Java to 2.3.0
  • 4b9bba6: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 9, 2022
@openjdk openjdk bot closed this Mar 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@TheRealMDoerr Pushed as commit bca1970.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant