Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit #868

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 9, 2022

Backport of JDK-8216137 (including JDK-8219520 as in original commit)
loopTransform.cpp (introduction of AutoNodeBudget) and loopnode.hpp required manual integration. Rest applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/868/head:pull/868
$ git checkout pull/868

Update a local copy of the PR:
$ git checkout pull/868
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/868/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 868

View PR using the GUI difftool:
$ git pr show -t 868

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/868.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 9, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e08506e6831667c17f1197345261f4c5e34294dc 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit Mar 9, 2022
@openjdk
Copy link

openjdk bot commented Mar 9, 2022

This backport pull request has now been updated with issues and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Mar 9, 2022
@TheRealMDoerr
Copy link
Contributor Author

Skara reports this as integration blocker: Title mismatch between PR and JBS for issue JDK-8219520. Fix:
/issue remove JDK-8219520

@openjdk
Copy link

openjdk bot commented Mar 9, 2022

@TheRealMDoerr
Removing additional issue from issue list: 8219520.

@mlbridge
Copy link

mlbridge bot commented Mar 9, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoeLin
Copy link
Member

GoeLin commented Mar 10, 2022

Pre-submit failures: dependencies missing.

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit

Adding simplistic node budget support for loop-transformations. This /should/attempts to/ resolve most cases of: "assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit".

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7d3db81: 8217340: Compilation failed: tools/launcher/Test7029048.java
  • c3628a2: 8245938: Remove unused print_stack(void) method from XToolkit.c
  • e18126a: 8252248: __SIGRTMAX is not declared in musl libc
  • 49f9105: 8252250: isnanf is obsolete
  • 8e01531: 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result
  • 85a89c5: 8211962: Implicit narrowing in MacOSX java.desktop jsound

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 10, 2022
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review and the approval!
/integrate

@openjdk
Copy link

openjdk bot commented Mar 10, 2022

Going to push as commit 04d8f98.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 194b66f: 8282225: GHA: Allow one concurrent run per PR only
  • 7d3db81: 8217340: Compilation failed: tools/launcher/Test7029048.java
  • c3628a2: 8245938: Remove unused print_stack(void) method from XToolkit.c
  • e18126a: 8252248: __SIGRTMAX is not declared in musl libc
  • 49f9105: 8252250: isnanf is obsolete
  • 8e01531: 8258956: Memory Leak in StringCoding on ThreadLocal resultCached StringCoding.Result
  • 85a89c5: 8211962: Implicit narrowing in MacOSX java.desktop jsound

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 10, 2022
@openjdk openjdk bot closed this Mar 10, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 10, 2022
@openjdk
Copy link

openjdk bot commented Mar 10, 2022

@TheRealMDoerr Pushed as commit 04d8f98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8216137_C2_node_limit branch March 10, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants