8277072: ObjectStreamClass caches keep ClassLoaders alive

[rkennke]

Hi all,

This pull request contains a backport of commit 8eb453ba from the openjdk/jdk repository.

The commit being backported was authored by Roman Kennke on 10 Dec 2021 and was reviewed by Roger Riggs and Peter Levart.

It fixes a memory leak in ObjectStreamClass under certain conditions. See bug for details.
The backport was not clean, there have been some rather minor differences in context.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8277072: ObjectStreamClass caches keep ClassLoaders alive

Reviewers

• Martin Doerr (@TheRealMDoerr - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/869/head:pull/869
$ git checkout pull/869

Update a local copy of the PR:
$ git checkout pull/869
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/869/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 869

View PR using the GUI difftool:
$ git pr show -t 869

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/869.diff

[bridgekeeper]

👋 Welcome back rkennke! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (5ec1e0b8)
• 00: Full (054c7215)

[TheRealMDoerr]

LGTM.

[openjdk]

@rkennke This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8277072: ObjectStreamClass caches keep ClassLoaders alive

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

• dbd14f7: 8277422: tools/jar/JarEntryTime.java fails with modified time mismatch
• dfcef29: 8241707: introduce randomness k/w to hotspot test suite
• b42dd74: 8280476: [macOS] : hotspot arm64 bug exposed by latest clang
• 73dc222: 8257794: Zero: assert(istate->_stack_limit == istate->_thread->last_Java_sp() + 1) failed: wrong on Linux/x86_32
• 6135540: 8223396: [TESTBUG] several jfr tests do not clean up files created in /tmp
• 9543488: 8247592: refactor test/jdk/tools/launcher/Test7029048.java
• 62afe2e: 8166727: javac crashed: [jimage.dll+0x1942] ImageStrings::find+0x28
• e1b2f92: 8279356: Method linking fails with guarantee(mh->adapter() != NULL) failed: Adapter blob must already exist!
• 38e44eb: 8199874: [TESTBUG] runtime/Thread/ThreadPriorities.java fails with "expected 0 to equal 10"
• ebf6a5b: 8207364: nsk/jvmti/ResourceExhausted/resexhausted003 fails to start
• ... and 30 more: https://git.openjdk.java.net/jdk11u-dev/compare/bca1970e865a87afc51f03cfd45b1745cc439331...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

Pre-submit failures: gcc missing, unrelated.

[rkennke]

/integrate

[openjdk]

Going to push as commit 118ec61.
Since your change was applied there have been 106 commits pushed to the master branch:

• 372e359: 8249592: Robot.mouseMove moves cursor to incorrect location when display scale varies and Java runs in DPI Unaware mode
• 0182066: 8239559: Cgroups: Incorrect detection logic on some systems
• 9bedb0f: 8279958: Provide configure hints for Alpine/apk package managers
• 57faad5: 8277922: Unable to click JCheckBox in JTable through Java Access Bridge
• e9896e2: 8255266: Update Public Suffix List to 3c213aa
• 89bf639: 8258795: Update IANA Language Subtag Registry to Version 2021-05-11
• 2faa216: 8247589: Implementation of Alpine Linux/x64 Port
• 19761f5: 8247591: Document Alpine Linux build steps in OpenJDK build guide
• b6f4e3e: 8210732: remove jdk.testlibrary.Utils
• c2e43f7: Merge
• ... and 96 more: https://git.openjdk.java.net/jdk11u-dev/compare/bca1970e865a87afc51f03cfd45b1745cc439331...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rkennke Pushed as commit 118ec61.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.