Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279668: x86: AVX2 versions of vpxor should be asserted #872

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Contributor

@shipilev shipilev commented Mar 10, 2022

Clean backport to prevent SIGILLs on incompatible hardware.

Additional testing:

  • Linux x86_64 fastdebug with -XX:UseAVX=1

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279668: x86: AVX2 versions of vpxor should be asserted

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/872/head:pull/872
$ git checkout pull/872

Update a local copy of the PR:
$ git checkout pull/872
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/872/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 872

View PR using the GUI difftool:
$ git pr show -t 872

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/872.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 10, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2bbeae3f056243a224b0bda021f16cdcbee3b3d6 8279668: x86: AVX2 versions of vpxor should be asserted Mar 10, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 10, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Mar 10, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 10, 2022

Webrevs

GoeLin
GoeLin approved these changes Mar 11, 2022
Copy link
Member

@GoeLin GoeLin left a comment

LGTM, only copyright resolved. (a candidate for /clean)

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2022

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8279668: x86: AVX2 versions of vpxor should be asserted

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 51b45e7: 8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11
  • 8770332: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace
  • 7d16719: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64
  • 04d8f98: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit
  • 194b66f: 8282225: GHA: Allow one concurrent run per PR only
  • 7d3db81: 8217340: Compilation failed: tools/launcher/Test7029048.java
  • c3628a2: 8245938: Remove unused print_stack(void) method from XToolkit.c
  • e18126a: 8252248: __SIGRTMAX is not declared in musl libc
  • 49f9105: 8252250: isnanf is obsolete

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 11, 2022
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Mar 11, 2022

Got the push approval.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2022

Going to push as commit 1123120.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 39974dc: 8186548: move jdk.testlibrary.JcmdBase closer to tests
  • 50ac138: 8210022: remove jdk.testlibrary.ProcessThread, TestThread and XRun
  • 9d3c940: 8218751: Do not store original classfiles inside the CDS archive
  • 51b45e7: 8282589: runtime/ErrorHandling/ErrorHandler.java fails on MacOS aarch64 in jdk 11
  • 8770332: 8208697: vmTestbase/metaspace/stressHierarchy/stressHierarchy012/TestDescription.java fails with OutOfMemoryError: Metaspace
  • 7d16719: 8212151: jdi/ExclusiveBind.java times out due to "bind failed: Address already in use" on Solaris-X64
  • 04d8f98: 8216137: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit
  • 194b66f: 8282225: GHA: Allow one concurrent run per PR only
  • 7d3db81: 8217340: Compilation failed: tools/launcher/Test7029048.java
  • c3628a2: 8245938: Remove unused print_stack(void) method from XToolkit.c
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/8e01531a547f7693387dfdefb6b2c18ed0ee1e68...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Mar 11, 2022
@openjdk openjdk bot closed this Mar 11, 2022
@openjdk openjdk bot removed ready rfr labels Mar 11, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Mar 11, 2022

@shipilev Pushed as commit 1123120.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8279668-vpxor-asserts branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants