Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268366: Incorrect calculation of has_fpu_registers in C1 linear scan #88

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Jun 30, 2021

Clean backport of 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268366: Incorrect calculation of has_fpu_registers in C1 linear scan

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/88.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 30, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 702e3ff05472e35140b38fd5a4d1266f4efdd7bb 8268366: Incorrect calculation of has_fpu_registers in C1 linear scan Jun 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 30, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268366: Incorrect calculation of has_fpu_registers in C1 linear scan

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 30, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Lgtm.

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Jul 1, 2021

Thanks for the review!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

Going to push as commit e56abca.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 3ed6237: 8269614: [s390] Interpreter checks wrong bit for slow path instance allocation
  • aa79d2b: 8262409: sun/security/ssl/SSLSocketImpl/SSLSocketImplThrowsWrongExceptions. SSL test failures caused by java failed with "Server reported the wrong exception"
  • 65fe466: 8269529: javax/swing/reliability/HangDuringStaticInitialization.java fails in Windows debug build
  • af4b373: 8163326: Update the default enabled cipher suites preference
  • 02bfc22: 8266749: AArch64: Backtracing broken on PAC enabled systems

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2021

@TheRealMDoerr Pushed as commit e56abca.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8268366_C1_11u branch Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants